apollo-storybook-decorator icon indicating copy to clipboard operation
apollo-storybook-decorator copied to clipboard

Angular package should be distributed as compiled JS, not TS

Open ghost opened this issue 5 years ago • 2 comments

Hi! I really appreciate that you've made an Angular version, but would it be possible to update your packaging process to run tsc --build on the Angular package before publishing it? I think it's fairly common to not recompile all dependencies in a Typescript workflow, so the decorator never actually gets compiled (at least with our workflow).

I'm not super familiar with Lerna, but I would guess it could simply be a matter of running a script from the inner package.json before completing the build.

Might also want to add main and types keys to the inner package.json as well, to help with resolutions.

If you'd prefer, I could try doing a PR for this, just let me know.

ghost avatar Dec 30 '19 21:12 ghost

I agree, that could be a really nice idea.

alexisponcet avatar Apr 29 '20 17:04 alexisponcet

Hi, is there any documentation on how to use the Angular version? I can’t find any

alanhobbart avatar Jan 28 '23 15:01 alanhobbart