boring_generators icon indicating copy to clipboard operation
boring_generators copied to clipboard

Published 20 hours ago • verified publisher icon abhaynikam

Add generator for rswag gem

Open coolprobn opened this issue 1 year ago • 3 comments

Tasks

  • Add generator for rswag gem
  • Sort generators in the Readme in alphabetical order

coolprobn avatar Apr 17 '23 11:04 coolprobn

@abhaynikam Could you take a look at this PR when you are free and let me know if you would like me to update anything?

Thanks for your time.

coolprobn avatar Apr 17 '23 12:04 coolprobn

It was intentionally designed to raise for error if rspec is missing insttead of running our generators to install it. This was based on the assumption that in a Rails project user will either have minitest or rspec, if the user is using minitest then it doesn't make sense for them to add another test framework.

image

coolprobn avatar Apr 18 '23 00:04 coolprobn

@abhaynikam Could you review this PR?

I have fixed the merge conflicts with the main branch now.

coolprobn avatar Jul 10 '23 15:07 coolprobn

@abhaynikam I have updated the code to reflect your suggestions and have added Authentication for API as well as UI instead of showing a message for users to configure themselves.

I have replied to your comment on why I don't think rspec should be installed by us if it doesn't already exist. Let us discuss on that if needed.

coolprobn avatar Mar 08 '24 21:03 coolprobn

@abhaynikam Bumping this up for the review from your side

coolprobn avatar Mar 20 '24 05:03 coolprobn