vsketch icon indicating copy to clipboard operation
vsketch copied to clipboard

Fill and stroke don't respect penWidth and overlap

Open ademuri opened this issue 1 year ago • 2 comments

When using both fill and stroke, they overlap:

image

I believe that they should instead be exclusive, taking into account the penWidth(s). In my example, the fill and stroke are different layers/strokes; this logic should take into account the width of both of those layers.

If you agree that this is a bug, I can look into this.

ademuri avatar Oct 06 '24 15:10 ademuri

In principle I agree that this is a bug. In practice, I'm slightly worried about the artefacts around shapes that have very "pointy" features (think of a very narrow, but very high, triangle). The additional overlap around the periphery minimizes the coverage holes, as in this illustration:

image

abey79 avatar Nov 21 '24 16:11 abey79

Ah, that's a good point. What do you think about adding a parameter for changing the inset amount? I just saw a request for this feature in the drawingbots discord, and I think it would be useful.

ademuri avatar Dec 02 '24 22:12 ademuri