abess icon indicating copy to clipboard operation
abess copied to clipboard

Update generate.spc.matrix.R

Open Mamba413 opened this issue 2 years ago • 2 comments

fix future bug from the update of Matrix

Mamba413 avatar Aug 26 '22 12:08 Mamba413

Codecov Report

Merging #450 (ff31d94) into master (d8abb7e) will decrease coverage by 3.64%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   93.52%   89.88%   -3.65%     
==========================================
  Files          29        9      -20     
  Lines        3212     1186    -2026     
==========================================
- Hits         3004     1066    -1938     
+ Misses        208      120      -88     
Flag Coverage Δ
Python 89.88% <ø> (ø)
rpackage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
R-package/R/generate.spc.matrix.R
R-package/R/extract.abess.R
R-package/R/coef.abess.R
R-package/R/plot.abess.R
R-package/R/coef.abessrpca.R
R-package/R/deviance.abess.R
R-package/R/print.abesspca.R
R-package/R/coef.abesspca.R
R-package/R/print.abessrpca.R
R-package/R/abessrpca.R
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 26 '22 12:08 codecov[bot]

Installation failure may be caused by the version of package 'Matrix'.

  • Reason Currently, the 'Matrix'version on CRAN is 1.4.1 and will be updated to 1.4.2 with API changes soon. The old code as(., "dgCMatrix") will be warned in the new version, and the new code as(as(as(., "dMatrix"), "generalMatrix"), "CsparseMatrix") will report an error in the old version. The description of Abess does not indicate the version of the Matrix. It is speculated that the automatic check of GitHub uses the old version on CRAN, so an error is reported.

  • Test code: library(Matrix) # 1.4.1 as(diag(4),'dMatrix') Error in as(diag(4), "dMatrix") : no method or default for coercing “matrix” to “dMatrix” library(Matrix) # 1.4.2 methods::as(diag(4), "dMatrix") 4 x 4 diagonal matrix of class "ddiMatrix" [,1] [,2] [,3] [,4] [1,] 1 . . . [2,] . 1 . . [3,] . . 1 . [4,] . . . 1

  • Debug

  1. Change the Matrix in DESCRIPTION to Matrix>=1.4.2 However, I don't know if the version is not available on CRAN, GitHub can install it or not. I installed it by downloading the new version source code package from the official website.

  2. Wait until 1.4.2 is available on CRAN.

bbayukari avatar Aug 27 '22 07:08 bbayukari