Jesse Rosenberger
Jesse Rosenberger
Superseded by https://github.com/apollographql/router/pull/5032, which did work and land. Best guess is CI cache is just busted on this PR because of underlying issues that existed on `dev` on the day...
I'm particularly unsure why we would ever cache it in Redis.
How important is this to jump on?
This relates to https://github.com/apollographql/router/issues/2687 and _was_ intentional because we were swallowing some error messages before. What was the impact to you? Was this just something you observed and were curious...
Does this PR get closed now?
@shorgi Could you re-review? Thanks!
@kindermax Can you try this again on the latest version and see what you find? A lot of validation actually was changed, so it may have also resolved this. Thanks!
I'm interested in merging this (or at least the first commit? Happy to give you contribution credit for sure if you want it though!) Have you been able to run...
If the answer is "the tests seem to fail but the image seems to work", I'm somewhat accepting of that as the status quo and would be game to publish...
Btw, I was incorrect. There is CI setup on this repository (it just doesn't run on forks) and tests are failing. I'll need to investigate if you can't — I...