evergreen icon indicating copy to clipboard operation
evergreen copied to clipboard

Spec files loading from their own file.

Open lightsofapollo opened this issue 13 years ago • 3 comments

Hi All,

When debugging one of the first things I noticed is the backtraces seem to lead nowhere because the specs are included directly in the HTML file for the view. I made a quick hack to load them from their own file (using Sinatra + File.read) and it seems to work fine and give me correct backtraces.

Is there a reason for not including these files vs embedding them? I can easily submit a patch if you like. I will probably commit this in a fork sometime today or tomorrow for my team to use either way.

Thank You, James Lal

lightsofapollo avatar Oct 10 '11 20:10 lightsofapollo

The original reason for doing this was that the specs silently passed if an error occurred while processing the specs. I guess though that wouldn't be a problem now, since we're rescuing errors and making them into failing specs anyway. We might want to do the same thing with 404's however.

jnicklas avatar Oct 11 '11 07:10 jnicklas

Great, I will write up a patch in the next few days. I have been (personally) using evergreen for the last 6 months now and I love it. The big difference it made however was getting the whole team up and running in less then an hour with a great test runner and selenium integration.

I hope to be able to contribute back something helpful.

lightsofapollo avatar Oct 11 '11 15:10 lightsofapollo

@lightsofapollo Did you ever get around to doing a patch? If not I might invest some time in this.

abepetrillo avatar Mar 17 '15 17:03 abepetrillo