satysfi-class-jlreq icon indicating copy to clipboard operation
satysfi-class-jlreq copied to clipboard

Fix problem on text-width

Open yasuo-ozu opened this issue 2 years ago • 5 comments

Problem

When we use multipul columns, the width of header and footer is shrinked to the column's width (as below).

Reference

yasuo-ozu avatar Jan 11 '23 03:01 yasuo-ozu

Limitations

When the page has some floating box, the origin point of all the columns are affect by the floating size. I think, it is the limitation of SATySFi's page-break-multicolumn primitive.

yasuo-ozu avatar Jan 11 '23 04:01 yasuo-ozu

Thank you! Why did you introduce header-footer-context? It seems that we don't need this for fixing this bug.

abenori avatar Jan 29 '23 06:01 abenori

Thanks for comment. Before this PR, the context of document and header (or footer) is commonalized, so the header and content should have same text-width. In this PR, I split the context for content and {header, footer}. After this PR, the user with lost the way to set the context of header, so I added new config header-footer-context. But I don't think the name is so suitable fot this purpose.

yasuo-ozu avatar Jan 30 '23 07:01 yasuo-ozu

Before this PR, the context of document and header (or footer) is commonalized, so the header and content should have same text-width.

That sounds not true. I think changing the argument to get-standard-context is sufficient as in your PR. So you don't need header-footer-context?

abenori avatar Feb 04 '23 04:02 abenori

I guess we don't have to introduce a new interface header-footer-context, so I only use half of your code 3ca206c. Thank you very much.

abenori avatar Apr 15 '23 00:04 abenori