Abel Salgado Romero

Results 275 comments of Abel Salgado Romero

I tested this because I am having a weird issue and I use Optionals, but I could not reproduce it. Whole tests runs fine (Windows 8.1, Java 8)

I'll see to get some time this week, just don't expect it until the weekend.

Thanks for the patience and time! I admit I am confused with your test You mention the test does not reproduce, but the code and running locally shows the values...

> I do not see empty values (and the test passes, proving that the list is not empty: assertFalse(parseResult.matchedArgs().isEmpty()). My mistake, I misread the assertion seeing the empty at the...

Modified the test to reproduce ```java package picocli; import org.junit.Test; import picocli.CommandLine.Command; import picocli.CommandLine.Option; import picocli.CommandLine.ParseResult; import java.util.List; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertSame; public class Issue2228...

> Thoughts? Firstly, if this is a breaking change, it's fine to delay for a major release. Then, also breaking change, why not remove `parseResult` from the method signature? If...

> I am sure there are use cases that require the full (top-level) parseResult. For example, there may be applications that need to inspect which options were specified on the...

Hi :wave: I'd like to continue the work from this PR. Does anyone have any objection?

Closing since https://github.com/asciidoctor/asciidoclet/pull/108 was merged. Many thanks to all!