Abel Salgado Romero

Results 278 comments of Abel Salgado Romero

Found the proper sink to use `getSink().figureGraphics()`

https://github.com/asciidoctor-lifecycle-maven/asciidoctor-lifecycle-maven-plugin already uses some. Maybe @rrialq :roll_eyes: would like to see what we need to integrate them?

> I can support with sonarcloud, i used it in different projects and we can define a specific quality goal based on our requirements. Go for it :rocket: I have...

I tried and I don't see it and I can't import the project. If @mojavelinux can add me as some admin I can continue with @uniqueck. Btw, what's the approach?...

> Thx Dan, Now it works, i can great a secret. @abelsromero can you give me access to that repository or you have to create that repository secrets. We need...

@uniqueck I elevated your permissions to Admin now. You should be able to handle secrets now. > Secrets need to be kept per repository. Definetly, no question about that.

Thanks a lot for the thorough detail, this helps a lot! This case is expected behaviour but can be improved and changed since we are working towards 3.x.x. The maven-plugin...

> but we're not saying when that will happen (as it depends on downdoc stabilizing). No issue at all, marking as "tracking" so we get a reminder to check from...

Fix merged upstream: https://github.com/apache/maven-doxia-sitetools/pull/16/

The fix has not yet been released, and contrary to what is mentioned in https://issues.apache.org/jira/browse/DOXIA-611 it's in v1.10. It's still possible to override `doxia-site-renderer` as in the example, but I...