Alfredo Beaumont
Alfredo Beaumont
Great points, thanks for sharing! I think we agree on some of those points and disagree on some others, let's explore them a bit more :) # 1. Versioning >...
I wanted also to draw some conclusions but didn't want to mix them with discussion, so I'll put them in a separate comment here. I'd say that we have different...
> My point is not that API groups are harmful, but is that this is a premature measure. We're shouldn't make very bold assumptions in the very beginning. Some design...
@dpaz Apart from the review changes, please rebase.
@mcarmonaa can you validate if everything is ok from your side?
@dpaz how does `linguist` implement those regexps?
It seems that the problem already appears at the DFM: ``` t13 := [PRIMOP raw-as-byte-character(^'c')] ```
I have failed to reproduce it with a minimal test case so far, since it seems to be optimization dependent.
Code to reproduce it: ``` dylan module: string-aref-test define function main () let t = "abcdefg"; let (a, b) = method() values(t[2], 'c') end(); format-out("%= %=\n", a, b); let (c,...
Generated DFM: ``` METHOD main () => (#rest results) t26 := [PRIMOP raw-as-byte-character(^'c')] Vt20 := [STACK-VECTOR (t26, ^'c')] [CONGRUENT-CALLi ^{ format-out ()}(^"%= %=\n", Vt20)] Vt16 := [STACK-VECTOR (^'c', ^'c')] [CONGRUENT-CALLi...