atom-figlet icon indicating copy to clipboard operation
atom-figlet copied to clipboard

Published 20 hours ago • verified publisher icon abe33

Fix issues with `getCommentStrings` for Atom 1.23+

Open danielhickman opened this issue 7 years ago • 2 comments

It now calls editor.getScopedSettingsDelegate().getCommentStrings(scope) if getCommentStrings doesn't exist. See: hydrogen/pull/1093

I continued to use the slightly more verbose ? operator because it seemed slightly better than a short circuit assignment and wrapped it across multiple lines because the API seems to have changed a bunch.

I tested it in 1.23 and 1.21. Fixes #9

danielhickman avatar Feb 02 '18 18:02 danielhickman

Yup, without this atom-figlet cannot be used anymore, please pull those PR in @abe33

marcofugaro avatar Apr 03 '18 13:04 marcofugaro

@abe33 Ping?

dead-claudia avatar Dec 13 '18 05:12 dead-claudia