abdulrahuman5196
abdulrahuman5196
@mollfpr Good catch on the regression and the order change in the workspace list. I have fixed the same and also updated the styles as per the recommendations. Kindly check...
@mollfpr Any updates on the review? I think I have closed out on all existing comments. Kindly let me know if anything else needs to be done at my end
@mollfpr for 1) I have fixed it. for 2) Currently there is no disable option in form.js submit component - https://github.com/Expensify/App/blob/main/src/components/Form.js#L326. I assume it has to do with us showing...
@luacmartins > 2. The way we should handle this is by showing an error on validate. Can we focus the search text input when the user presses `fix the errors`?...
## Proposal ### Please re-state the problem that we are trying to solve in this issue. When keyboard is open on the new member invite page, the user list and...
>@abdulrahuman5196 Could you provide the screenshot for your suggestion before we ask for the design team's opinion? @mollfpr I asked the design team's opinion because there are multiple UI ways...
Sure will go through this in my morning
Hi, @blazejkustra I understand the requirements. Doesn't it seem odd to have the form types in a separate folder or files? I don't see much re-usability of the page specific...
Hi, @blazejkustra Sorry, Didn't see the last comment. Will re-review now
@blazejkustra I did check on high level and have no further comments. But given the PRs size and test range, I would need probability today and tomorrow(hopefully today alone) to...