python-elgato-streamdeck icon indicating copy to clipboard operation
python-elgato-streamdeck copied to clipboard

Published 20 hours ago • verified publisher icon abcminiuser

Revert to known-good header for StreamDeck Original V1

Open Subsentient opened this issue 4 years ago • 2 comments

Fixes https://github.com/abcminiuser/python-elgato-streamdeck/issues/47

Subsentient avatar Jun 26 '20 10:06 Subsentient

What's odd is that I have a StreamDeck Original V1, and I can't see the shifting. Looking at the packet dumps between the old/new versions the only difference I can spot is the overall length, where the old code doesn't pad the packets to the report length boundary.

Can you please try the latest head, but with padding = bytearray() (i.e. no padding) in StreamDeckOriginalV1.py? In theory it shouldn't make any difference, but there might be a USB controller or firmware bug that's only showing up on some systems.

abcminiuser avatar Jun 27 '20 01:06 abcminiuser

What's odd is that I have a StreamDeck Original V1, and I can't see the shifting. Looking at the packet dumps between the old/new versions the only difference I can spot is the overall length, where the old code doesn't pad the packets to the report length boundary.

Can you please try the latest head, but with padding = bytearray() (i.e. no padding) in StreamDeckOriginalV1.py? In theory it shouldn't make any difference, but there might be a USB controller or firmware bug that's only showing up on some systems.

Just tried it, something must be going on because that fix doesn't work. Only the pull request does.

Subsentient avatar Jun 27 '20 10:06 Subsentient