react-native-af-video-player icon indicating copy to clipboard operation
react-native-af-video-player copied to clipboard

No exit control for fullscreen mode

Open AwayQu opened this issue 6 years ago • 3 comments

  • [x] React Native version & OS:
  • [x] react-native-af-video-player version:
 "react-native-af-video-player": "^0.2.1",
Environment:
  OS: macOS High Sierra 10.13.5
  Node: 8.9.1
  Yarn: 1.7.0
  npm: 5.5.1
  Watchman: 3.9.0
  Xcode: Xcode 9.3.1 Build version 9E501
  Android Studio: 3.1 AI-173.4819257

Packages: (wanted => installed)
  react: 16.3.1 => 16.3.1
  react-native: 0.55.4 => 0.55.4
  • [x] Code and explanation to replicate this issue:

No exit control for full screen.

  • [x] Include Screeshots / Video:
screen shot 2018-07-02 at 22 01 32

AwayQu avatar Jul 02 '18 14:07 AwayQu

This screenshot is not very helpful and there's no code.

abbasfreestyle avatar Jul 03 '18 09:07 abbasfreestyle

there is no any icon on the video player to exit fullscreen mode.

ruk91 avatar Aug 15 '18 06:08 ruk91

The problem is caused by the computation of the full screen size. Dimensions.get('window').height is used but on iphone X XR XS, one need to substract bottom and top margins, otherwise controls are hidden underneath the bottom bar.

We have a first version of a fix:

	height:
		Dimensions.get('window').height -
		getBottomSpace() -
		getStatusBarHeight(),
	width: Dimensions.get('window').width
   };

That also need to be handled on orientation change. @abbasfreestyle any idea how to handle this properly ?

ganmor avatar Jan 20 '19 08:01 ganmor