dmix
dmix copied to clipboard
abarisain
Get LocalCover filename from listfiles
Some features I would like to have for covers :
- Add support for multiple cover album
- Change the localcover fetcher to ask the MPD server for the content of the album directory to find images instead of trying to download predefined image file names.
I just wanted to know if anyone is working on these features to avoid making the work twice ?
Multiple album covers is on my radar, should be easy to implement the rest of the way down. How do you intend to query the server about album covers?
Awesome. I'll take a look at that next time I'm at the keyboard. I've already refactored localcover, so, I'll take care of this as well.
We already achieve this via the http server. Is this something new?
On Sun, Sep 13, 2015 at 12:19 PM, Avuton Olrich [email protected] wrote:
Multiple album covers is on my radar, should be easy to implement the rest of the way down. How do you intend to query the server about album covers?
— Reply to this email directly or view it on GitHub https://github.com/abarisain/dmix/issues/758#issuecomment-139892215.
The difference is for now MPDroid uses a predefined list of image names to download them from the http server. The new idea is to ask to the MPD server the files contained in the album folder in order to be able to use an image even if it has a non standard name. And it should also reduce the number of http requests.
Got it. This potentially will make things a bit messy. I guess you will have to place all your image files within the same folder as your music files. In my case, I have a folder named "scans" will all the images I scanned, hence "scans". Maybe we should let MPDroid specify a "scans" folder? Also, and this is for the future, more and more album I buy from the web have a booklet.pdf file, some contain liner notes and some contain all the images. I believe we should also look into this as well.
Thanks,
Ran
On Sun, Sep 13, 2015 at 3:55 PM, jcnoir [email protected] wrote:
The difference is for now MPDroid uses a predefined list of image names to download them from the http server. The new idea is to ask to the MPD server the files contained in the album folder in order to be able to use an image even it has a non standard name. And it should also reduce the number of http requests.
— Reply to this email directly or view it on GitHub https://github.com/abarisain/dmix/issues/758#issuecomment-139912977.
Don't worry @rompolompo . This will be smartly implemented and likely seamless to the end user.
No worries. Just my 2 cents.
On Sun, Sep 13, 2015 at 4:02 PM, Avuton Olrich [email protected] wrote:
Don't worry @rompolompo https://github.com/rompolompo . This will be smartly implemented and likely seamless to the end user.
— Reply to this email directly or view it on GitHub https://github.com/abarisain/dmix/issues/758#issuecomment-139913314.
And when we will have multi cover support for an album this will allow to display all images (pdf ...) available in this album folder. Nice feature I think !
Changed the name, multiple covers is covered under another issue and I hate multiple issue issues.