godot-ci icon indicating copy to clipboard operation
godot-ci copied to clipboard

add wine, rcedit, update to focal

Open monban opened this issue 4 years ago • 8 comments

This PR does the following:

  • Updates Ubuntu to focal, by using the latest version of git we can use the Checkout action v2
  • Installs wine, this is required to use rcedit
  • Downloads rcedit to /usr/loca/bin, required to change / correct the icon on build Windows executables
  • Makes downloads quiet, less spam in the build log

Contributor Edit: Fixes https://github.com/aBARICHELLO/godot-ci/issues/21

monban avatar Oct 23 '20 03:10 monban

As per the conversation above, I've changed --quiet to --no-verbose. Also I'm wondering if it would be a good idea to document somewhere as to how to use rcedit? Here is roughly what I'm doing on github actions:

      - name: Setup
        run: |
          chown -R root:root $HOME
          mkdir -v -p ~/.local/share/godot/templates
          mv /root/.local/share/godot/templates/${GODOT_VERSION}.stable ~/.local/share/godot/templates/${GODOT_VERSION}.stable
      - name: Windows Desktop Build
        run: |
          mkdir -v -p $GITHUB_WORKSPACE/build/windows-desktop
          cd $GITHUB_WORKSPACE/src
          godot -v --export "Windows Desktop" $GITHUB_WORKSPACE/build/windows-desktop/$EXPORT_NAME.exe
      - name: Convert png to ico
        run: convert $GITHUB_WORKSPACE/src/assets/common/textures/icons/icon.png -define icon:auto-resize="256,128,96,64,48,32,16" ~/icon.ico
      - name: Change exe icon
        run: cd $GITHUB_WORKSPACE; wine $GITHUB_WORKSPACE/rcedit.exe $GITHUB_WORKSPACE/build/windows-desktop/$EXPORT_NAME.exe --set-icon ~/icon.ico

In any event, please re-review and let me know if I can help by touching up the documentation anywhere.

monban avatar Oct 24 '20 22:10 monban

@monban If you'd like you can add a note at the bottom of README on how to use it, and/or a comment to the gitlab and github config scripts.

realkotob avatar Oct 25 '20 15:10 realkotob

Pipelines are working https://gitlab.com/BARICHELLO/godot-ci/-/pipelines/207459332

abarichello avatar Oct 27 '20 02:10 abarichello

Using wine for the rcedit with GitHub actions is failing with this error message: wine: '/__w/godot-ci/godot-ci' is not owned by you, refusing to create a configuration directory there Action log: https://github.com/aBARICHELLO/godot-ci/runs/1371907817?check_suite_focus=true

Also act is giving me different results locally, testing this is a real pain.

abarichello avatar Nov 09 '20 02:11 abarichello

Yeah, unfortunately you need to chown the home directory when running from GithubActions, here is an example of usage, (note the chown on line 30) I've been trying to figure out if there is a better way to accomplish this, hence why I haven't created the above referenced documentation yet...

monban avatar Nov 09 '20 07:11 monban

@monban do you have any updates on this?

2shady4u avatar Apr 19 '21 20:04 2shady4u

You know what, I completely forgot about this, I'm sorry. I'll get on this after work today, expect an update in the next couple of hours.

monban avatar Apr 19 '21 21:04 monban

This looks really useful. Is there any chance of this getting updated and merged? @monban

Deozaan avatar Nov 08 '21 07:11 Deozaan

@Deozaan If you are interesting in picking this up feel free to open a new PR with the changes.

realkotob avatar Dec 25 '22 08:12 realkotob

If you are interesting in picking this up feel free to open a new PR with the changes.

I've looked into it briefly and I think it's beyond my skill level. 😳😬

Deozaan avatar Jan 04 '23 18:01 Deozaan

At this point I no longer recommend people to use rcedit, but rather to use Godot Icon instead.

monban avatar Mar 19 '23 23:03 monban