vscode-abaplint icon indicating copy to clipboard operation
vscode-abaplint copied to clipboard

Extension 'larshp.vscode-abaplint' uses a document selector without scheme. Learn more about this: https://go.microsoft.com/fwlink/?linkid=872305

Open larshp opened this issue 6 years ago • 5 comments

Extension 'larshp.vscode-abaplint' uses a document selector without scheme. Learn more about this: https://go.microsoft.com/fwlink/?linkid=872305

due to https://github.com/abaplint/vscode-abaplint/pull/10 ?

@marcellourbani

image

larshp avatar Dec 24 '18 08:12 larshp

Most likely

But I think it's a red herring:

Documents are usually stored on the file system, but not always: there are untitled documents, cached documents that Git uses, documents from remote sources like FTP, and so forth. If your feature relies on disk access, make sure to use a document selector with the file scheme.

As far as I understand/saw it doesn't, so it shouldn't. Not only for my extension, also for files accessed over ftp/in a zip file,... In my first implementation I had a multiple selector with file and ADT, then I removed that selector as I think you don't need it. I wonder if * works

These days I'm working on my old, slooooow laptop in Italy, won't be really able to play with it before 28th (spent a day trying to get an environment working for my own extension. Like 2h active and the rest waiting or hanging out and celebrating, still the lead time is stupidly long )

marcellourbani avatar Dec 24 '18 09:12 marcellourbani

dont worry, everything seems to work, just get the warning when running the extension

merry christmas 🎄

larshp avatar Dec 24 '18 09:12 larshp

Merry christmas

marcellourbani avatar Dec 24 '18 10:12 marcellourbani

this issue can probably be fixed after https://github.com/abaplint/vscode-abaplint/issues/21

larshp avatar Aug 25 '19 09:08 larshp

I think so! Let's hope it gets released soon. It should as they're pushing a lot on remote filesystems

marcellourbani avatar Aug 26 '19 08:08 marcellourbani