abaplint-sci-server icon indicating copy to clipboard operation
abaplint-sci-server copied to clipboard

Logging

Open sbcgua opened this issue 5 years ago • 6 comments

What kind of logging is required ? And what are the levels?

Currently there is that addInfo that keeps last 10 requests and visible from the frontpage.

In reality I think there are 3 categories of entries:

  • requests (maybe just in "dev" mode) and time of their serving (this what morgan does in the PR)
  • details of check_object (also debug in fact ? or needed for statistics?)
  • errors

I think all of the can go to console. Docker can redirect that to any other service "in production".

On the other hand there is the public service. Do you suppose to leave it ? Anyway I think the logs should be hidden from there and better to redirect it to a logging service, maybe even public one.

@larshp what do you think ?

sbcgua avatar Mar 24 '20 11:03 sbcgua

I think its low priority

larshp avatar Mar 24 '20 11:03 larshp

Generally agree, but let me refocus a bit. Do we need log at the frontpage ? (I'd suggest removing it)

sbcgua avatar Mar 24 '20 18:03 sbcgua

I find the logging on the frontpage quite useful. What you saw in https://github.com/abaplint/abaplint-sci-client/issues/188 could have been identified that way, for example (if I had looked ;-) ).

Instead of the last 10 requests, it would make a bit more sense to show all requests from the last 5 min or so. This would make it easier to correlate client and server activities.

mbtools avatar Oct 09 '20 21:10 mbtools

if it's useful, then it's useful, no prob :) Just to clearly understand the purpose - it is not scalable, only for quick dev.

sbcgua avatar Oct 10 '20 07:10 sbcgua

btw: @mbtools @larshp how do you run this thing ? I mean, I just so natively run and see it from command line that tools like that frontpage look for me very unnatural. What is your use case ? @ed-holland uses portainer as I undersood, there should be the console log output

sbcgua avatar Oct 10 '20 07:10 sbcgua

Details are showing up like this (using verbose=1) image

ed-holland avatar Oct 10 '20 09:10 ed-holland