abapTimeMachine icon indicating copy to clipboard operation
abapTimeMachine copied to clipboard

v740sp02

Open larshp opened this issue 4 years ago • 2 comments

not to be merged, just for getting list of errors

larshp avatar Jul 07 '21 11:07 larshp

Great. Thanks! I'll look into these as soon as I have some time.

nununo avatar Jul 08 '21 16:07 nununo

if you set "require branches to be up to date" in the branch protection, its easy to pull the latest changes from main branch in to this branch

larshp avatar Jul 17 '21 06:07 larshp

(I just found out that email replies don't support Markdown so I'm cutting this and pasting it in a new proper comment.)

nununo avatar Mar 15 '23 17:03 nununo

Hi Lars,

I am finally having a little time to dedicate to abapTimeMachine. I noticed you closed this so I replicated it in another branch so that I can go through the list of linter errors and deal with them. But to be honest I'm having a hard time making sense of any of them.

Here it is: https://github.com/abapinho/abapTimeMachine/pull/129/files?diff=unified&w=0

None of them seem to make sense to me, though. I wonder if I'm doing something wrong. For example, the very first one says this:

Check failure on line 140 in src/zcl_timem_diff.clas.abap Statement does not exist in ABAPv740sp02(or a parser error), "result" https://rules.abaplint.org/parser_error

about this statement:

result = VALUE abaptxt255_tab(
  FOR s_line IN it_line
  ( line = process_line( s_line-source ) ) ).

But I don't find anything strange in it. I don't have a 740 system which I can use to test it though. But, as far as I know, this is a valid 740 statement.

Another example is this:

Check failure on line 58 in src/zcl_timem_gui.clas.abap Class or type "zcl_timem_gui_handler" not found https://rules.abaplint.org/check_syntax

related to this line of code:

DATA(handler) = NEW zcl_timem_gui_handler( me ).

Again, I don't see anything wrong here.

The linter is probably right but I'm having a hard time understanding these results. Can you please point me to how I can figure these out?

Thanks!

nununo avatar Mar 15 '23 17:03 nununo