ADT_Backend icon indicating copy to clipboard operation
ADT_Backend copied to clipboard

refactor zcl_abapgit_default_auth_info

Open larshp opened this issue 5 years ago • 4 comments

refactor zcl_abapgit_default_auth_info, it is part of core abapGit no need to have it implemented twice

larshp avatar Feb 25 '19 13:02 larshp

zcl_abapgit_default_auth_info is currently not part of core abapGit. Either we bring it to core or we enhance zcl_abapgit_login_manager.

mfsap avatar Apr 16 '19 15:04 mfsap

which enhancements are needed in zcl_abapgit_login_manager ?

larshp avatar Apr 16 '19 15:04 larshp

To avoid having several classes for credentials, it would be nice having one single class (zcl_abapgit_login_manager). It should "store" username/pw for a given repository as long as the session is alive. The current implementation have a setter for username/pw. It would be perfect if it gets a getter method for username/pw as well.

mfsap avatar Apr 16 '19 16:04 mfsap

Then we can eliminate zcl_abagit_default_auth_info and use the login manager as substitude.

mfsap avatar Apr 16 '19 16:04 mfsap