abap2xlsx icon indicating copy to clipboard operation
abap2xlsx copied to clipboard

Readerclass - Errors with autofilter

Open StefanSchmoecker opened this issue 9 years ago • 8 comments

1.) If ZCL_EXCEL_READER_2007 finds an autofilter which has no filter critera ( filter just exists ) it hides all lines that are mentioned in the autofilter, even though they do not meet any filter criteria

2.) If a worksheet has an autofilter assigned for some columns and later this autofilter gets switched off, the ZCL_EXCEL_READER_2007 still sees the previous autofilter

StefanSchmoecker avatar Apr 08 '15 09:04 StefanSchmoecker

  1. corrected with revision 445

StefanSchmoecker avatar Apr 09 '15 20:04 StefanSchmoecker

ad 2) If filtervalues are present, they are being ignored by readerclass completly. This will result in an existing autofilter appearing and the lines that were filtered out by the original autofilter are hidden but the autofilter is not showing that it is responsible for this hiding of rows

StefanSchmoecker avatar Apr 11 '15 12:04 StefanSchmoecker

  1. Autofilters with multiple values shown: Hidden-status of rows not calculated correctly
  2. Only single-values filter supported, missing features: Text- and Numberfilters with filter rules
  3. When adding a new autofilter with ZCL_EXCEL->ADD_NEW_AUTOFILTER to a sheet that already has an autofilter, then the existing autofilter is returned instead of an exception ( or the method is named poorly )
  4. Class ZCL_EXCEL_AUTOFILTERS is very inconsistent in worksheet-parameter of the various methods. When a worksheet is needed as parameter it is sometimes expected as TYPE REF TO ZCL_EXCEL_WORKSHEET and sometime as TYPE UUID. The latter is somewhat unexpected - this is the first time I have realized we have an UUID for the sheets and I AM working with A2X. I consider switching the parameter to "TYPE ANY" with a comment that we accept either worksheet or uuid and make these methods behave in a uniform way

**) I like the fact that the constant C_AUTOFILTER is part of class ZCL_EXCEL_AUTOFILTERS. ( This is needed by the reader- and writerclass to examine/build the ixml document ). But unfortunately this approach ends here. In my opinion this class could take over (at least part of) the reading/creating of the ixml structures in the reader and writerclass. But this is something that could be said of some other classes as well,would require some redesigning in the reader- and writerclasses and should be discussed in the otherwise quite deserted SAP Community Network - Open Source space

StefanSchmoecker avatar Apr 12 '15 08:04 StefanSchmoecker

Some issues solved with latest build - I'll update the topic to reflect which problems remain and which have been solved

StefanSchmoecker avatar Aug 09 '15 10:08 StefanSchmoecker

Followup: Which problems have been solved or which have arisen with V 7-_0_5 Autofilters not written out correctly any more,
Reader still doesn't read in filter area correctly

StefanSchmoecker avatar Aug 15 '15 09:08 StefanSchmoecker

So there is no possibility to select more values for one filter of one column?

miskohut avatar Jun 09 '16 07:06 miskohut

@miskohut the issue is in the reader class... If you generate an excel you're able to select multiple values

ivanfemia avatar Jun 09 '16 14:06 ivanfemia

@ivanfemia Hi, please check issue #440, there is problem with multiple values in writer class as well.

miskohut avatar Jun 10 '16 07:06 miskohut