noble
noble copied to clipboard
abandonware
Binding options
transfer from https://github.com/noble/noble/pull/651
To use two different devices in one setup you need to configure the binding in your code and not with ENV-Vars.
I am using one device for connecting while the other keeps on collecting advertisements.
I startet it already, but it needs more effort then I originally thought and I currently have very little spare time at hand. So this is gonna take some time. If someone else wants to jump in, feel free.
On 5. Oct 2020, at 13:49, Philippe Coval [email protected] wrote:
this PR needs to be rebased, or you can submit smaller changes
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abandonware/noble/pull/121#issuecomment-703580459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYW6OJ6WV6NXLTMU25TTDSJGXDBANCNFSM4RNCOJ3Q.
Would it make sense that we close this PR, you can split this changeset into several smaller PR ?
Hi @bitcloud , I took your PR on my own dev env, and I only 14 changes, not 119 as yours. I think you have a problem with CR/LF (or any other) on git.
Please see https://github.com/abandonware/noble/pull/155
I didn't test / try code, simply take it back (a fix a typo cancle to cancel).
@rzr this change (at least as it is described in the post) was merged in #155 and released in v1.9.2-12.
The diff for this PR is quite large, and contains other, unrelated changes. @atrovato has pulled out out other features (see #174) and the rest is left in #185.
I believe this PR can be rejected/closed. Disclaimer: I'm just a user of this library (thanks for keeping it maintained!)
