zlib-sync icon indicating copy to clipboard operation
zlib-sync copied to clipboard

chore: bump nan from 2.18.0 to 2.22.2

Open Renegade334 opened this issue 5 months ago • 3 comments

This is enough to unlock building up to Node.js v24, plus or minus a ton of deprecation warnings.

Renegade334 avatar Jul 08 '25 19:07 Renegade334

Hi @abalabahaha, any chance this could be looked at soon?

Jiralite avatar Nov 10 '25 13:11 Jiralite

Should this be bumped to 2.23.1 instead, as that's the latest version now?

almeidx avatar Nov 10 '25 14:11 almeidx

This does force an update, but I wonder if this is even necessary. The existing ^2.18.0 means >=2.18.0,<3.0.0 so I don't think the library is preventing you from using a newer version of nan. However, if you have nan locked to 2.18.0 in your package-lock.json, your package manager will probably keep that until you tell it to bump things.

What happens if you run npm update (or your package manager's equivalent)? That should bump all your dependencies to the latest versions compatible with your version constraints. If that doesn't fix it, I'd be curious to see your package.json dependencies and dependency tree.

abalabahaha avatar Nov 10 '25 17:11 abalabahaha