eris
eris copied to clipboard
feat(shards): Support Non-Sequential Shard IDs
This PR adds support for non-sequential shardsIDs to be used in eris. Currently I wrote it to override firstShardID and lastShardID if any numbers exist in the array. But I can see valid cases for the following as well:
- Throw an error if both firstShardID/lastShardID and shardIDs are defined
- firstShardID/lastShardID take priority and must be set to null for shardIDs to be used
Please let me know if I should change the logic to reflect one of these other states or to something entirely different if someone has a better idea.
I have performed basic testing of this and seems fine, but I want to test it more thoroughly before we merge.
Closes #1385
#1385 related
Marking this as a draft until #1384 is merged, as it makes more sense to just do these together rather then immediately deprecating options.shardIDs