Add new Google Authentication mechanism provider

[Heatmanofurioso]

Currently, the fix for https://github.com/abacritt/angularx-social-login/issues/489, was to update to the newest Google Authentication mechanism, which seems to be working, but we are forced to have further steps when signing in, which doesn't seem to make much sense.

This issue is to discuss & work on 2 things. Decide if we wish to keep this method and add a new one, or just replace it for a more optimal solution.

Work & collaborate on a more optimal solution for Google Authentication.

[isaacfi]

Is there any way to not upgrade the angular version to use this fix? I'm actually using the 12 version

[isaacfi]

I updated to 13 and the button does not appear:

In the package.json

"dependencies": {
  "@abacritt/angularx-social-login": "1.1.0",

And in the HTML:

<div class="d-flex mb-2">
        <button type="button" class="btn facebook-btn" (click)="submitFacebookLogin()"><i
            class="fab fa-facebook-square"></i> {{'loginWithFacebook' | translate}}</button>
        <asl-google-signin-button></asl-google-signin-button>
</div>

In the console, I'm still seeing (this had to be gone, right?):

For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
node_modules/webpack-dev-server/client/modules/logger/index.js:556
Your client application uses libraries for user authentication or authorization that will soon be deprecated. See the [Migration Guide](https://developers.google.com/identity/gsi/web/guides/gis-migration) for more information.

BR.

[Heatmanofurioso]

@isaacfi You can always open a PR from our latest V12 version, cherry-pick the changes onto it, and push it into a v12 support branch.

We're currently only maintaining support for V13 & V14, but I'd be happy to deploy a version of it if someone did that work.

Anyway, this issue shouldn't be the discussion point for that. If you wish to do these changes, or want to discuss them. maybe open a discussion on https://github.com/abacritt/angularx-social-login/discussions, or a PR

[rat-matheson]

@Heatmanofurioso I'm stuck on angular v12 so I will try your suggestion and do a PR for v12.

I believe this is the commit, right?

~Commit to cherry pick~ ~Edit: It's this one pull/507~ Edit: now I see the challenge, more than 20 commits to cherry-pick. I'll give er a go and see how she works out

I'm having difficulty finding a v12 or v12 support branch. Can you point me in the right direction?

abacritt/angularx-social-login/branches/all

Edit: I think I need to create a new v12-support branch from this commit, right?

Edit 2: Currently blocked based on issues/592 - having issues with the google provider even in the default demo app

[Heatmanofurioso]

Hi @rat-matheson It's hard to suggest on that. What you can do, is locally change the minimum version to 12, and test it out to see if it doesn't break.

If it's fine, you can add a PR with it.

I think V12 might have full compatibility

[rat-matheson]

@Heatmanofurioso That's a good approach. I will try that if I can get unblocked. I'm currently stuck on this issue though where I can't even get the demo app to work properly for google.

update Aug 30: I've unblocked on the other issue, and have been mostly successful using the method you suggested. I will submit the branch after a bit more testing

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[rat-matheson]

This should be reopened until the change is merged in. All the updates are complete, just waiting for the merge

[aneshodza]

Can anyone update me on this issue? I updated to version 4.1.0, which should fix it, but non the less I keep getting the error: