angularx-social-login icon indicating copy to clipboard operation
angularx-social-login copied to clipboard

Add lazy load of login providers SDKs to prevent setting excess cookies before it's needed

Open mbarouski opened this issue 7 years ago • 8 comments

Description:

Would be good to have opportunity to laod login providers SDKs after some moment to prevent loading of login providers cookies before this moment.

Will try to add such functionality. Maybe it will be merged to master.

mbarouski avatar Jan 10 '19 18:01 mbarouski

There is no option for lazyLoad in the latest version Angular 9/10,

prem6667 avatar Sep 30 '20 18:09 prem6667

Right, these changes got omitted in version 3 refactoring. I am in the middle of refactoring the login providers again due to #280. I need to incorporate this as well.

jaibatrik avatar Oct 01 '20 06:10 jaibatrik

Lazyload has been incoprated with fix of #280 ?

raphaelApard avatar Nov 15 '20 23:11 raphaelApard

I made a try here : https://github.com/acolad-developpement/angularx-social-login/commit/4890f0c02dc16ed0b4f99bf3144b0a92f7182628 I'm not sure it's the best way to achieve this, but it works for signIn. Can we reach signOut without signIn initialization ?

raphaelApard avatar Nov 22 '20 00:11 raphaelApard

I made a try here : acolad-developpement@4890f0c I'm not sure it's the best way to achieve this, but it works for signIn. Can we reach signOut without signIn initialization ?

Someone can choose to call it I think; though it doesn't make sense. The autoLogin itself does not make sense with lazy load.

jaibatrik avatar Nov 28 '20 16:11 jaibatrik

Yes if lazyLoad is enabled, autoLogin is ignored

raphaelApard avatar Nov 28 '20 17:11 raphaelApard

I think this issue needs to be re-open

raphaelApard avatar Dec 16 '20 21:12 raphaelApard

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 15 '21 07:02 stale[bot]