onlineStore
onlineStore copied to clipboard
aawgit
Add unit tests
Hello! I have started adding the test. I can see there is some not-too-good solutions in code and missing part. I am working on these and push them to review when it is in deployable state.
Hello, Thanks. I'm doing some refactoring to facilitate unit tests. Please wait till I merge those to the master branch. Thanks again.
On Sat, May 16, 2020, 21:43 Mátyás Angyal [email protected] wrote:
Hello! I have started adding the test. I can see there is some not-too-good solutions in code and missing part. I am working on these and push them to review when it is in deployable state.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aawgit/onlineStore/issues/15#issuecomment-629669380, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILBQLV3XCX6E5HC6WH7CF3RR23UNANCNFSM4M44425Q .
No, tests can be added.
On Fri, May 29, 2020, 06:48 uaalumni02 [email protected] wrote:
Has the testing been complete?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aawgit/onlineStore/issues/15#issuecomment-635701517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILBQLVMEDZKDJACZIVEVT3RT4EOJANCNFSM4M44425Q .
Hey! can Test still be added? I'm looking forward to contribute for the first time in an open source project. So is there a scope ?
Yes, it's possible to add tests. I think back end code is a good place to start. I suggest using Jest, but feel free to bring up another framework if you prefer.
Thanks for letting me know! I'll start if off and update you with my progress!
is there anyway to contact you as i had some doubts because it's my first time.
No worries. Feel free to contact me via LinkedIn: https://www.linkedin.com/in/akalanka-weerasooriya-7812b3171/
Hello, is this issue resolved? bcoz I am looking forward to contribute in this, Please let me know.
Could you give me some guidelines to start.
Sure, let me add a few tests, then it will be easier for you to start. It might take a couple of days. I'll keep you posted.
Hello, is this issue resolved? bcoz I am looking forward to contribute in this, Please let me know.
There is still room to add tests.
Could you give me some guidelines to start.
@phoneix007 I have added one test under server/test/controller. Please feel free to contact me if you need any clarification.
@aawgit Are you still in need of more unit tests? I would love to contribute!
@aawgit Are you still in need of more unit tests? I would love to contribute!
Yes
