protocol-v2 icon indicating copy to clipboard operation
protocol-v2 copied to clipboard

`LendingPool.swapBorrowRateMode` natspec documentation for the `rateMode` parameter is misleading

Open StErMi opened this issue 2 years ago • 1 comments

The current natspec documentation for the rateMode parameter on the LendingPool.swapBorrowRateMode functions states

@param rateMode The rate mode that the user wants to swap to

From a user prospective, it seems that you should pass the rateMode that you want to switch your debt INTO Instead, the function requires you to pass the CURRENT rateMode that you are using for your debt position.

Honestly, I think that the best UX would be to specify the rateMode you would like to swap to, but changing the natspec is much less complex than changing the whole logic of the function.

StErMi avatar Sep 14 '23 07:09 StErMi

+1 I just noticed this too

SimkoCarlos avatar Oct 29 '23 18:10 SimkoCarlos