interface icon indicating copy to clipboard operation
interface copied to clipboard

Atoken symbols when adding to wallet are wrong

Open sakulstra opened this issue 2 years ago • 3 comments

Describe the bug Tokens are added as a${TokenName} which strictly speaking is wrong (only on eth mainnet the symbol is a${TokenName} - it's different on every other pool.

To Reproduce Steps to reproduce the behavior:

  1. Go to app.aave.com
  2. Add a aToken to your wallet

Expected behavior The token name should be correct, otherwise it's confusing with dexes who show the correct name.

Additional context Might make sense to just return the aTokenSymbol from the uiPoolDataProvider as it's generally not as simple as adding a prefix to the underlying symbol. Idk know though how reasonable it is to fetch all the symbols and names every few seconds. Might be more reasonable to actually split this in two requests where the one responsible for symbol and so on would be fetched a lot less frequently (for most tokens it's essentially static).

sakulstra avatar Jul 16 '22 10:07 sakulstra

@sakulstra @drewcook @defispartan is this still an issue? I looked and can't find "a${TokenName}" in the codebase and when looking at the AddTokenDropdown component. It pulls from the poolReserve

Jdecristi avatar May 24 '23 23:05 Jdecristi

image

I think it's still an issue ( in this case should be aOptDai https://optimistic.etherscan.io/address/0x82E64f49Ed5EC1bC6e43DAD4FC8Af9bb3A2312EE )

sakulstra avatar May 25 '23 07:05 sakulstra

@sakulstra after looking into it, I found that UiPoolDataProvider, where the aTokenAddress is provided, doesn't provide the aTokenSymbol. This fix should be fixed in the @aave/contract-helpers module

Jdecristi avatar Jun 16 '23 19:06 Jdecristi