interface icon indicating copy to clipboard operation
interface copied to clipboard

feat/rwc updated design

Open defispartan opened this issue 2 years ago • 24 comments

  • New design for repay w/ collateral modal
  • New design for collateral swap modal
  • Factor slippage amount into the maximum repayable debt for the selected collateral. Now, if the user presses the 'max' button on the debt asset when repaying, the amount inserted will take into account the slippage. This only happens when the balance of the selected asset to repay with (minus slippage) is less than the debt amount.
  • Frozen assets are no longer available to select in the repay with collateral modal
  • The slippage for the swap modal was ignoring the user selected value and was just hard coded to 1%. This will now use the selected value in the modal

defispartan avatar Jun 28 '22 04:06 defispartan

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 509.22 KB (🟡 +2.93 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 39.24 KB (🟢 -73 B) 548.46 KB
/staking 32.12 KB (🟢 -178 B) 541.34 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Jun 28 '22 04:06 github-actions[bot]

  • Ipfs hash: bafybeidipruwmu2nlaw6odaosc2pqesddoafvvv2lr7sbtywzntqturjve
  • Ipfs preview link: https://bafybeidipruwmu2nlaw6odaosc2pqesddoafvvv2lr7sbtywzntqturjve.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jun 28 '22 04:06 github-actions[bot]

  • Ipfs hash: bafybeih5f7q4xta65svjb7hzcptj7fhrfnvoualx5c4tyumvhl3wot2wta
  • Ipfs preview link: https://bafybeih5f7q4xta65svjb7hzcptj7fhrfnvoualx5c4tyumvhl3wot2wta.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jun 30 '22 05:06 github-actions[bot]

  • Ipfs hash: bafybeihwqxanaqbybpqacz3grdgaitzbcmmah2u5zcdb2dm7zyfe4dncs4
  • Ipfs preview link: https://bafybeihwqxanaqbybpqacz3grdgaitzbcmmah2u5zcdb2dm7zyfe4dncs4.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jun 30 '22 17:06 github-actions[bot]

  • Ipfs hash: bafybeiboea6d4ra34d2nqrgnds4u5blxhosbeha2o5ggwyu6tojzf2j2n4
  • Ipfs preview link: https://bafybeiboea6d4ra34d2nqrgnds4u5blxhosbeha2o5ggwyu6tojzf2j2n4.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jun 30 '22 19:06 github-actions[bot]

  • Ipfs hash: bafybeifhdsgjy6zaf7bk4vg4uckwwzmivdxigwm63g77x4uvbzh2wx7nfa
  • Ipfs preview link: https://bafybeifhdsgjy6zaf7bk4vg4uckwwzmivdxigwm63g77x4uvbzh2wx7nfa.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jun 30 '22 20:06 github-actions[bot]

need to merge main into this pr to fix the tests

MareskoY avatar Jul 05 '22 14:07 MareskoY

  • Ipfs hash: bafybeicjap6atlcsbkwzdqb4xwm7wrdfa26zv5d5fsesgwe45tddzbmk6m
  • Ipfs preview link: https://bafybeicjap6atlcsbkwzdqb4xwm7wrdfa26zv5d5fsesgwe45tddzbmk6m.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jul 12 '22 01:07 github-actions[bot]

  • Ipfs hash: bafybeie3agkfh7bseei3sd57q22fkyvrmltksryoa5f4mfcv2au2ixyqfe
  • Ipfs preview link: https://bafybeie3agkfh7bseei3sd57q22fkyvrmltksryoa5f4mfcv2au2ixyqfe.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jul 21 '22 20:07 github-actions[bot]

  • Ipfs hash: bafybeiawpstgggnqso5gkrsmi7xkdsv6snnp2nhvi3e7pnabjmpfe73vom
  • Ipfs preview link: https://bafybeiawpstgggnqso5gkrsmi7xkdsv6snnp2nhvi3e7pnabjmpfe73vom.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jul 25 '22 19:07 github-actions[bot]

  • Ipfs hash: bafybeih74ufj3kxous36bmmztq2u7nldxqsuz5xuslalxjsektg724ia4m
  • Ipfs preview link: https://bafybeih74ufj3kxous36bmmztq2u7nldxqsuz5xuslalxjsektg724ia4m.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jul 25 '22 21:07 github-actions[bot]

  • Ipfs hash: bafybeiaf6l5tackjnayhefsegtbjff27teedi2wqfavf4kdistq53gs3tq
  • Ipfs preview link: https://bafybeiaf6l5tackjnayhefsegtbjff27teedi2wqfavf4kdistq53gs3tq.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jul 25 '22 22:07 github-actions[bot]

  • Ipfs hash: bafybeidoxkaciclar64sb22rovwk4gtkrov6mp7bhdxohrpxzksefbukri
  • Ipfs preview link: https://bafybeidoxkaciclar64sb22rovwk4gtkrov6mp7bhdxohrpxzksefbukri.ipfs.cf-ipfs.com/

github-actions[bot] avatar Jul 26 '22 13:07 github-actions[bot]

  • Ipfs hash: bafybeia5q7a7dozwjpmylwkuistce6vjmuap6dmnl4j7snxhcxonpyzywu
  • Ipfs preview link: https://bafybeia5q7a7dozwjpmylwkuistce6vjmuap6dmnl4j7snxhcxonpyzywu.ipfs.cf-ipfs.com/

github-actions[bot] avatar Aug 16 '22 18:08 github-actions[bot]

  • Ipfs hash: bafybeiehecox56hqxny6nx3qzcwv7iy3yepgvhtlmv6qdjgys3pvrvmjzy
  • Ipfs preview link: https://bafybeiehecox56hqxny6nx3qzcwv7iy3yepgvhtlmv6qdjgys3pvrvmjzy.ipfs.cf-ipfs.com/

github-actions[bot] avatar Aug 18 '22 18:08 github-actions[bot]

  • Ipfs hash: bafybeih455it3ya4l3z4rvqsm5akcmdwjjfwspjbcpdd7gljy4lbjhaqkq
  • Ipfs preview link: https://bafybeih455it3ya4l3z4rvqsm5akcmdwjjfwspjbcpdd7gljy4lbjhaqkq.ipfs.cf-ipfs.com/

github-actions[bot] avatar Aug 18 '22 18:08 github-actions[bot]

  • Ipfs hash: bafybeidzy3zaauhq4vgsqssfm4tkubse5nortxiel2fh6xesp7syy7l2ce
  • Ipfs preview link: https://bafybeidzy3zaauhq4vgsqssfm4tkubse5nortxiel2fh6xesp7syy7l2ce.ipfs.cf-ipfs.com/

github-actions[bot] avatar Aug 18 '22 18:08 github-actions[bot]

  • Ipfs hash: bafybeidlshh2yannos73sba5gi2kvccvpqdvaxuw6pcrcbvwjbtmpgaufq
  • Ipfs preview link: https://bafybeidlshh2yannos73sba5gi2kvccvpqdvaxuw6pcrcbvwjbtmpgaufq.ipfs.cf-ipfs.com/

github-actions[bot] avatar Aug 29 '22 13:08 github-actions[bot]

  • Ipfs hash: bafybeicltz6wn6ypvezd32owgg4w2bmucfm4pajdocpasnaub7got4ukxe
  • Ipfs preview link: https://bafybeicltz6wn6ypvezd32owgg4w2bmucfm4pajdocpasnaub7got4ukxe.ipfs.cf-ipfs.com/

github-actions[bot] avatar Sep 14 '22 09:09 github-actions[bot]

  • Ipfs hash: bafybeicl4t3u5ionrzd5hpooaqyeh4wpee2nxjaois2ciuzdm4cmoybsmy
  • Ipfs preview link: https://bafybeicl4t3u5ionrzd5hpooaqyeh4wpee2nxjaois2ciuzdm4cmoybsmy.ipfs.cf-ipfs.com/

github-actions[bot] avatar Sep 14 '22 09:09 github-actions[bot]

  • Ipfs hash: bafybeicvvioxn3gr6rwf4rf3gxo4xeu7ch4xmbbxyjaoajqooozjl4u77u
  • Ipfs preview link: https://bafybeicvvioxn3gr6rwf4rf3gxo4xeu7ch4xmbbxyjaoajqooozjl4u77u.ipfs.cf-ipfs.com/

github-actions[bot] avatar Sep 14 '22 14:09 github-actions[bot]

  • Ipfs hash: bafybeia5o77hqmm5ok5hvfaw7io5xzhz7z3e7swrscocacac2eyuf2ujgy
  • Ipfs preview link: https://bafybeia5o77hqmm5ok5hvfaw7io5xzhz7z3e7swrscocacac2eyuf2ujgy.ipfs.cf-ipfs.com/

github-actions[bot] avatar Sep 15 '22 14:09 github-actions[bot]

  • Ipfs hash: bafybeifuhhzrw2mkvjnkbfclxlzy62op2j43cbx77denxmz4v6kp6trseq
  • Ipfs preview link: https://bafybeifuhhzrw2mkvjnkbfclxlzy62op2j43cbx77denxmz4v6kp6trseq.ipfs.cf-ipfs.com/

github-actions[bot] avatar Sep 16 '22 09:09 github-actions[bot]

How does this relate to #1219? Should this PR be closed out in favor of it?

drewcook avatar Nov 20 '22 21:11 drewcook