interface icon indicating copy to clipboard operation
interface copied to clipboard

fix: fix Horizon banner redirection when navigating from the sGHO page

Open AGMASO opened this issue 3 months ago • 5 comments

General Changes

  • fixed Horizon banner redirection when navigating from the sGHO page

Developer Notes

  • Could currentMarket change while we’re on the /sGho page? This might be an edge case. I don’t think it’s possible. We can’t add currentMarket to the useEffect dependency array because it conflicts with the banner redirection.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • [ ] End-to-end tests are passing without any errors
  • [ ] Code changes do not significantly increase the application bundle size
  • [ ] If there are new 3rd-party packages, they do not introduce potential security threats
  • [ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

AGMASO avatar Sep 16 '25 16:09 AGMASO