interface icon indicating copy to clipboard operation
interface copied to clipboard

fix: gho debt amount

Open grothem opened this issue 10 months ago • 9 comments

General Changes

  • Updates utils packages which includes fix properly calculating a users gho debt balance with a discount applied
  • Updates reserves in app data provider in the case where the user does have a gho discount so the correct amount can be used throughout the app
  • Fixes a bug where the discount rate wasn't being factored into the users weighted average borrow apy displayed

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • [ ] End-to-end tests are passing without any errors
  • [ ] Code changes do not significantly increase the application bundle size
  • [ ] If there are new 3rd-party packages, they do not introduce potential security threats
  • [ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

grothem avatar Feb 12 '25 22:02 grothem

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 4:48pm
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 4:48pm

vercel[bot] avatar Feb 12 '25 22:02 vercel[bot]

  • Ipfs hash: bafybeifccbwszdb4jyr2m6hkufie4ln26aryxpizfkocivnv4h73eyjc7i
  • Ipfs preview link: https://bafybeifccbwszdb4jyr2m6hkufie4ln26aryxpizfkocivnv4h73eyjc7i.ipfs.cf-ipfs.com/

github-actions[bot] avatar Feb 12 '25 22:02 github-actions[bot]

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 858.78 KB (🟡 +114 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] avatar Feb 12 '25 22:02 github-actions[bot]

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 858.78 KB (🟡 +113 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] avatar Feb 13 '25 16:02 github-actions[bot]

  • Ipfs hash: bafybeigd2gm54embsuqehtda73i63uslsh3ady4h5v6aettfklxnye27py
  • Ipfs preview link: https://bafybeigd2gm54embsuqehtda73i63uslsh3ady4h5v6aettfklxnye27py.ipfs.cf-ipfs.com/

github-actions[bot] avatar Feb 13 '25 16:02 github-actions[bot]

  • Ipfs hash: bafybeih566jyjgqtegj767vol4ab3mkw4wnya3hbiulsjfrqlnsqnwaj5u
  • Ipfs preview link: https://bafybeih566jyjgqtegj767vol4ab3mkw4wnya3hbiulsjfrqlnsqnwaj5u.ipfs.cf-ipfs.com/

github-actions[bot] avatar Feb 13 '25 17:02 github-actions[bot]

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 858.78 KB (🟡 +113 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] avatar Feb 13 '25 17:02 github-actions[bot]

  • Ipfs hash: bafybeichklh3imaoymot534i7qnhxapwt6pjih7su5qs3djq4ouo675hdy
  • Ipfs preview link: https://bafybeichklh3imaoymot534i7qnhxapwt6pjih7su5qs3djq4ouo675hdy.ipfs.cf-ipfs.com/

github-actions[bot] avatar Feb 17 '25 16:02 github-actions[bot]

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 858.79 KB (🟡 +123 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] avatar Feb 17 '25 16:02 github-actions[bot]