interface icon indicating copy to clipboard operation
interface copied to clipboard

feat: add message about flash loan fee when required

Open grothem opened this issue 6 months ago • 5 comments

General Changes

  • Adds in a notice when a flash loan is required for collateral swap or repay with collateral
  • This does not apply on debt swaps since debt swaps are approved flash borrowers in the protocol
  • Just hardcoded the flash loan fee values for now, which seems ok. We could fetch these values from the pool, if we need to in the future.

image


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • [ ] The base branch is set to main
  • [ ] The title is using Conventional Commit formatting
  • [ ] The Github issue has been linked to the PR in the Development section
  • [ ] The General Changes section has been filled out
  • [ ] Developer Notes have been added (optional)

If the PR is ready for review:

  • [ ] The PR is in Open state and not in Draft mode
  • [ ] The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • [ ] End-to-end tests are passing without any errors
  • [ ] Code style generally follows existing patterns
  • [ ] Code changes do not significantly increase the application bundle size
  • [ ] If there are new 3rd-party packages, they do not introduce potential security threats
  • [ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • [ ] Code changes have been quality checked in the ephemeral URL
  • [ ] QA verification has been completed
  • [ ] There are two or more approvals from the core team
  • [ ] Squash and merge has been checked

grothem avatar Aug 01 '24 22:08 grothem