interface icon indicating copy to clipboard operation
interface copied to clipboard

feat: add XDEFI Wallet option

Open HoangVD2 opened this issue 1 year ago • 5 comments

General Changes

  • add XDEFI wallet option

Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • [x] The base branch is set to main
  • [x] The title is using Conventional Commit formatting
  • [ ] The Github issue has been linked to the PR in the Development section
  • [x] The General Changes section has been filled out
  • [ ] Developer Notes have been added (optional)

If the PR is ready for review:

  • [x] The PR is in Open state and not in Draft mode
  • [ ] The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • [ ] End-to-end tests are passing without any errors
  • [ ] Code style generally follows existing patterns
  • [ ] Code changes do not significantly increase the application bundle size
  • [ ] If there are new 3rd-party packages, they do not introduce potential security threats
  • [ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • [ ] Code changes have been quality checked in the ephemeral URL
  • [ ] QA verification has been completed
  • [ ] There are two or more approvals from the core team
  • [ ] Squash and merge has been checked

HoangVD2 avatar Mar 22 '24 08:03 HoangVD2

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

height[bot] avatar Mar 22 '24 08:03 height[bot]

Hi, Aave team!

This PR adds the XDEFI wallet to the list of supported wallets.

Please let us know if anything needs to be added or changed to satisfy your requirements.

XDEFI Wallet team.

https://github.com/aave/interface/assets/102846781/a09bb8ee-8aff-4521-922a-e2bf5e2fc97d

HoangVD2 avatar Mar 22 '24 08:03 HoangVD2

Thank you @HoangVD2 Maybe @grothem or @marczeller could approve it 🖖 ?

davidp94 avatar Mar 22 '24 09:03 davidp94

I'd love to, but frontend is controlled by Avara, not the DAO.

I've been fighting for a Rabby option for years at this point.

marczeller avatar Mar 22 '24 09:03 marczeller

Thanks for the PR @HoangVD2

We're actually in the process of updating the wallet connection libraries so we're not looking to make any changes to this right now.

Also, regrading the rabby option, it can be used today in the interface by selecting the 'Browser wallet' option in the connection modal. Should be the same with xdefi as well.

grothem avatar Mar 25 '24 14:03 grothem

wont support at this time

foodaka avatar Aug 02 '24 12:08 foodaka