interface icon indicating copy to clipboard operation
interface copied to clipboard

test: add tests for timeHelper file

Open kodakyellow opened this issue 1 year ago • 4 comments
trafficstars

General Changes

  • add test coverage for timeHelper.tsx file

Developer Notes

Screenshot 2024-02-08 at 10 30 35

Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • [ ] The base branch is set to main
  • [ ] The title is using Conventional Commit formatting
  • [ ] The Github issue has been linked to the PR in the Development section
  • [ ] The General Changes section has been filled out
  • [ ] Developer Notes have been added (optional)

If the PR is ready for review:

  • [ ] The PR is in Open state and not in Draft mode
  • [ ] The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • [ ] End-to-end tests are passing without any errors
  • [ ] Code style generally follows existing patterns
  • [ ] Code changes do not significantly increase the application bundle size
  • [ ] If there are new 3rd-party packages, they do not introduce potential security threats
  • [ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • [ ] Code changes have been quality checked in the ephemeral URL
  • [ ] QA verification has been completed
  • [ ] There are two or more approvals from the core team
  • [ ] Squash and merge has been checked

kodakyellow avatar Feb 08 '24 19:02 kodakyellow

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

height[bot] avatar Feb 08 '24 19:02 height[bot]

@foodaka @JoaquinBattilana Am i using the correct workflow by forking the repo, then submitting a pr back to main repo. Let me know if there is anything else i'm missing in this pr. I want to dive deeper into Aave repo and become a regular contributor. Thanks

kodakyellow avatar Feb 09 '24 17:02 kodakyellow

@kodakyellow you can follow the contributing guidelines here https://github.com/aave/interface/blob/main/CONTRIBUTING.md , thanks for the contribution

foodaka avatar Feb 12 '24 08:02 foodaka

@kodakyellow you can follow the contributing guidelines here https://github.com/aave/interface/blob/main/CONTRIBUTING.md , thanks for the contribution

thank you, this pr came from a forked repo as the guidelines have stated. However, I was not able to follow the guidline for naming branche since this pr didn't resolve any bug issue or add new features, instead i looked for low hanging fruits like adding some tests in this pr (since its my first pr for this repo). The changes are ready for review. Thanks cc @foodaka

kodakyellow avatar Feb 13 '24 18:02 kodakyellow