interface icon indicating copy to clipboard operation
interface copied to clipboard

Standardize Pool approval amounts

Open defispartan opened this issue 1 year ago • 1 comments

supply, repay, repayWithPermit, and supplyWithPermit are all approving underlying tokens to the Pool contract. Some approvals use a max approval while others use per-tx allowance. This should be standardized or give the option to select max approval vs per-tx.

defispartan avatar Oct 03 '23 01:10 defispartan

Hey just to add some context to this, there are some cases that we absolutely need max approval, for example for repayWithPermit if you want to do a max repay you need to pass a signature with max approval because it validates it in the contracts

JoaquinBattilana avatar Oct 18 '23 21:10 JoaquinBattilana