interface icon indicating copy to clipboard operation
interface copied to clipboard

Add improvements to pwa

Open Jdecristi opened this issue 1 year ago • 1 comments

General Changes

  • Fixes PWA issues with IOS splash screens

Developer Notes

Added IOS spashscreens in separate component. I'm not sure if this increases bundle size? However, after looking at the stats when building it doesn't seem to be an issue.

Screen Capture

There are a few improvements to this change:

  1. The install button is now clear after adding the "any maskable" tag

Screenshot 2023-08-11 at 4 22 16 PM

  1. The splash screens are now available on any IOS Device.

Screen Capture

Before After
Screenshot Screenshot

Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • [x] The base branch is set to main
  • [x] The title is using Conventional Commit formatting
  • [x] The General Changes section has been filled out
  • [x] Developer Notes have been added (optional)

If the PR is ready for review:

  • [x] The PR is in Open state and not in Draft mode
  • [ ] The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • [ ] End-to-end tests are passing without any errors
  • [ ] Code style generally follows existing patterns
  • [ ] Code changes do not significantly increase the application bundle size
  • [ ] If there are new 3rd-party packages, they do not introduce potential security threats
  • [ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • [ ] Code changes have been quality checked in the ephemeral URL
  • [ ] QA verification has been completed
  • [ ] There are two or more approvals from the core team
  • [ ] Squash and merge has been checked

Jdecristi avatar Aug 11 '23 20:08 Jdecristi

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

height[bot] avatar Aug 11 '23 20:08 height[bot]