interface
interface copied to clipboard
fix: Link T-1628 error handling improvements
General Changes
Fixes: T-1628 Tx History Potential Improvements
https://github.com/aave/interface/assets/26067720/d0b3521c-e687-41d5-a347-53c6bec8a248
https://github.com/aave/interface/assets/26067720/34eab680-3191-43c9-974d-b836648018c3
Developer Notes
Add any notes here that may be helpful for reviewers.
- [x] Error handling on fetchForDownload with Json + Csv downloads
- [x] Fix validateDOMNesting errors in HistoryFilterMenu
- [x] Use theme variables where applicable instead of hardcoded colors
Author Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
- [x] The base branch is set to
main
- [x] The title is using Conventional Commit formatting
- [x] The Github issue has been linked to the PR in the Development section
- [x] The General Changes section has been filled out
- [x] Developer Notes have been added (optional)
If the PR is ready for review:
- [x] The PR is in
Open
state and not inDraft
mode - [x] The
Ready for Dev Review
label has been added
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
- [x] End-to-end tests are passing without any errors
- [x] Code style generally follows existing patterns
- [x] Code changes do not significantly increase the application bundle size
- [x] If there are new 3rd-party packages, they do not introduce potential security threats
- [x] If there are new environment variables being added, they have been added to the
.env.example
file as well as the pertinant.github/actions/*
files - [x] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
- [x] Code changes have been quality checked in the ephemeral URL
- [ ] QA verification has been completed
- [ ] There are two or more approvals from the core team
- [ ] Squash and merge has been checked
Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword
link
(e.g. "Link T-123").💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.