interface icon indicating copy to clipboard operation
interface copied to clipboard

feat: add coinbase as an onramp item

Open cfluke-cb opened this issue 2 years ago • 2 comments

General Changes

  • Adds Coinbase pay feature as an onramp item

Developer Notes

the NEXT_PUBLIC_COINBASE_API_KEY we prefer to not be committed, we realize that it is discoverable, but prefer not to be searchable/indexed


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • [x] The base branch is set to main
  • [x] The title is using Conventional Commit formatting
  • [ ] The Github issue has been linked to the PR in the Development section
  • [x] The General Changes section has been filled out
  • [x] Developer Notes have been added (optional)

If the PR is ready for review:

  • [ ] The PR is in Open state and not in Draft mode
  • [ ] The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • [ ] End-to-end tests are passing without any errors
  • [ ] Code style generally follows existing patterns
  • [ ] Code changes do not significantly increase the application bundle size
  • [ ] If there are new 3rd-party packages, they do not introduce potential security threats
  • [ ] If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • [ ] Code changes have been quality checked in the ephemeral URL
  • [ ] QA verification has been completed
  • [ ] There are two or more approvals from the core team
  • [ ] Squash and merge has been checked

cfluke-cb avatar Nov 09 '22 15:11 cfluke-cb

gm,

Is there a governance post to go with this? UX/UI changes require a governance proposal first.

0x4Graham avatar Nov 10 '22 12:11 0x4Graham

gm, We are still finalizing the proposal. Hopefully should post by Monday

cfluke-cb avatar Nov 10 '22 13:11 cfluke-cb

we are not ramping through UI

foodaka avatar Nov 21 '23 15:11 foodaka