aave-v3-core
aave-v3-core copied to clipboard
There is so many warning in the aave-v3-core
npm run test
show warning bellow:
--> contracts/protocol/libraries/aave-upgradeability/BaseImmutableAdminUpgradeabilityProxy.sol:23:15:
|
23 | constructor(address admin) {
| ^^^^^^^^^^^^^
Note: The other declaration is here:
--> contracts/protocol/libraries/aave-upgradeability/BaseImmutableAdminUpgradeabilityProxy.sol:39:3:
|
39 | function admin() external ifAdmin returns (address) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning: This declaration shadows an existing declaration.
--> contracts/protocol/tokenization/base/IncentivizedERC20.sol:72:27:
|
72 | constructor(IPool pool, string memory name, string memory symbol, uint8 decimals) {
| ^^^^^^^^^^^^^^^^^^
Note: The shadowed declaration is here:
--> contracts/protocol/tokenization/base/IncentivizedERC20.sol:81:3:
|
81 | function name() public view override returns (string memory) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning: This declaration has the same name as another declaration.
--> contracts/protocol/tokenization/base/IncentivizedERC20.sol:72:47:
|
72 | constructor(IPool pool, string memory name, string memory symbol, uint8 decimals) {
| ^^^^^^^^^^^^^^^^^^^^
Note: The other declaration is here:
--> contracts/protocol/tokenization/base/IncentivizedERC20.sol:86:3:
|
86 | function symbol() external view override returns (string memory) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning: This declaration has the same name as another declaration.
--> contracts/protocol/tokenization/base/IncentivizedERC20.sol:72:69:
|
72 | constructor(IPool pool, string memory name, string memory symbol, uint8 decimals) {
| ^^^^^^^^^^^^^^
Note: The other declaration is here:
--> contracts/protocol/tokenization/base/IncentivizedERC20.sol:91:3:
|
91 | function decimals() external view override returns (uint8) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning: This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
--> contracts/dependencies/openzeppelin/upgradeability/InitializableUpgradeabilityProxy.sol:11:1:
|
11 | contract InitializableUpgradeabilityProxy is BaseUpgradeabilityProxy {
| ^ (Relevant source part starts here and spans across multiple lines).
Note: The payable fallback function is defined here.
--> contracts/dependencies/openzeppelin/upgradeability/Proxy.sol:17:3:
|
17 | fallback() external payable {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning: This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
--> contracts/protocol/libraries/aave-upgradeability/BaseImmutableAdminUpgradeabilityProxy.sol:16:1:
|
16 | contract BaseImmutableAdminUpgradeabilityProxy is BaseUpgradeabilityProxy {
| ^ (Relevant source part starts here and spans across multiple lines).
Note: The payable fallback function is defined here.
--> contracts/dependencies/openzeppelin/upgradeability/Proxy.sol:17:3:
|
17 | fallback() external payable {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning: This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
--> contracts/protocol/libraries/aave-upgradeability/InitializableImmutableAdminUpgradeabilityProxy.sol:13:1:
|
13 | contract InitializableImmutableAdminUpgradeabilityProxy is
| ^ (Relevant source part starts here and spans across multiple lines).
Note: The payable fallback function is defined here.
--> contracts/dependencies/openzeppelin/upgradeability/Proxy.sol:17:3:
|
17 | fallback() external payable {
| ^ (Relevant source part starts here and spans across multiple lines).
If I deal these warning, and pull requests, do you guys will think about to accept the commit?