django-pymssql icon indicating copy to clipboard operation
django-pymssql copied to clipboard

Advertise Django 1.8 compatibility -- no code changes required

Open roodie opened this issue 10 years ago • 14 comments

Hello, any news on the Django 1.8 compatibility front? What's the problem exactly?

roodie avatar Jun 24 '15 13:06 roodie

I haven't tested this with Django 1.8 yet - have you? It may work. If it isn't, could you send what error / problems you're having? Django 1.6 -> 1.7 introduced some pretty major database changes (migrations), but 1.7 -> 1.8 may be a drop in. I know for pyodbc, my upgrade from 1.7 to 1.8 was only made difficult by the dropping of the 'name' column in django_content_type (it is now a property).

FlipperPA avatar Jun 24 '15 13:06 FlipperPA

I have ugraded a project that uses this library to Django 1.8 and it just worked.

I haven't taken the time to run Django's entire test suite (it takes ages) and check if it still passes.

aaugustin avatar Jun 24 '15 14:06 aaugustin

I figured it would, thanks. roodie, if you're having an issue with 1.8, include some details and I'll try to help you out.

FlipperPA avatar Jun 24 '15 14:06 FlipperPA

Django-mssql has some failures with the Django test suite related to date math, expressions, and aggregates. I have fixes for many of these in master already, but not pushed to pypi.

manfre avatar Jun 24 '15 15:06 manfre

... which gives me a good excuse for not testing until @manfre pushes a 1.8-compatible release of django-mssql ;-)

aaugustin avatar Jun 24 '15 16:06 aaugustin

Now this is interesting - I have 2 virtualenvs, the only difference I see is the Django version. I am sure all pre-requisites for django-pymssql are ok in both, but I get the following error when I switch to the 1.8 version:

django.core.exceptions.ImproperlyConfigured: 'sqlserver_pymssql' isn't an available database backend. .. Error was: cannot import name BaseDatabaseWrapper

I will try to recreate the virtualenv to see what went wrong.

roodie avatar Jun 24 '15 21:06 roodie

You may need to build django-mssql from git master branch.

aaugustin avatar Jun 25 '15 07:06 aaugustin

Well, a bit late, but you were right - I downloaded and installed the current master version, and everything seems to be working now. Thanks!

roodie avatar Jul 24 '15 17:07 roodie

Hmm... I think it is not too polite when installing, it uninstalled my django 1.8.6 and installed django 1.7.10 without warning or my confirmation.

ggiraffe avatar Nov 06 '15 07:11 ggiraffe

Yeah, the problem is this block:

install_requires=[
    'Django >=1.7, <1.8',
    'django-mssql',
    'pymssql',
],

However, that's just because the dependency django-mssql doesn't support 1.8.

FlipperPA avatar Nov 06 '15 15:11 FlipperPA

I removed the check on the Django version in ed572efabbc2365aabbd4caaec24c5d2a37a8d03.

aaugustin avatar Nov 06 '15 16:11 aaugustin

I was talking with @manfre earlier today. He almost has a version of django-mssql that passes the test suite of Django 1.8. Once he makes a release I can advertise Django 1.8 support.

aaugustin avatar Nov 06 '15 16:11 aaugustin

Ah, that'll be great, I didn't know you were headed in that direction, or I would have issued a P.R. This will be great, since 1.8 has LTS and there are rumblings about support Python 3.5 in Django 1.8 as well.

FlipperPA avatar Nov 06 '15 16:11 FlipperPA

Django has reached 1.10 since then and I haven't caught up.

Actually I'm no longer working with SQL Server and I'm unlikely to maintain this library going forward. If someone is interested in maintaining it, please file an issue and let me know.

aaugustin avatar Aug 22 '16 20:08 aaugustin