haaukins icon indicating copy to clipboard operation
haaukins copied to clipboard

Changed markdown parser to as markdown didnt match gitlab.

Open Mikkelhost opened this issue 2 years ago • 2 comments

Changed markdown renderer, apparently old renderer was not CommonMark compliant. So the mark down parsed from readme on gitlab did not look the same in the webclient.

Mikkelhost avatar Jun 09 '22 13:06 Mikkelhost

Reconsider if it makes sense to use bluemonday at all, since you're already taking "trusted" input, ie. not user specified input. Doesn't seem to make sense to use Goldmark with unsafe HTML, and then try to sanitize it afterwards.

eyJhb avatar Aug 09 '22 09:08 eyJhb

Reconsider if it makes sense to use bluemonday at all, since you're already taking "trusted" input, ie. not user specified input. Doesn't seem to make sense to use Goldmark with unsafe HTML, and then try to sanitize it afterwards.

I think when i created this i pretty much went from a zero trust perspective. And i think it is a good idea to keep it as a zero trust. For the goldmark with unsafe html, i will take a look, i havn't really done anything else thank making it work :)

Mikkelhost avatar Aug 09 '22 09:08 Mikkelhost