Alessandro Arzilli

Results 358 comments of Alessandro Arzilli

We changed things in delve so now the changes need to be ported to build-tools: https://github.com/go-delve/build-tools/pull/2

It should be ok to merge now. For the 1.25 failures in teamcity see https://github.com/go-delve/delve/pull/4089

Needs https://github.com/go-delve/build-tools/pull/3

> I think DAP is hard to change in short time All of the changed I suggested in the PR are in the DAP implementation in delve.

I don't understand what you are saying, but it sounds strange. I also don't understand what is going on in that video that you posted in https://github.com/go-delve/delve/pull/4078#discussion_r2293981698.

Ok, I see what you mean now. The problem is that the loop in `addTarget` in `pkg/proc/target_group.go` should be sending `EventBreakpointMaterialized` events.

Maybe `eventsFn` should even be a member of `TargetGroup`.

> Defers are handled in this patch specifically because they are an explicit feature of Go and one of the most common dynamic dispatch types used within a Go program...

Sorry to not have reviewed this yet, but I have been busy this past month and I will continue to be busy for a while still.

Please see the [FAQ about breakpoints in complicated debugging environments](https://github.com/go-delve/delve/blob/master/Documentation/faq.md#-can-not-set-breakpoints-or-see-source-listing-in-a-complicated-debugging-environment). If that doesn't help please explain this in terms I can understand: what's a kubernetes admission webhook, how is it...