nx-dark-reader icon indicating copy to clipboard operation
nx-dark-reader copied to clipboard

Published 20 hours ago • verified publisher icon aartaka

Parity between Dark-Reader Extension

Open AblatedSprocket opened this issue 2 years ago • 2 comments

Should this work on all the same sites as the Firefox extension? My litmus test was https://html.duckduckgo.com/html which the Firefox extension recolors but nx-dark-reader does not.

AblatedSprocket avatar Oct 14 '23 15:10 AblatedSprocket

nx-dark-reader lacks support for dynamic theme fixes that WebExtensions-based DarkReader bundles. There are a lot (~27000 lines) of dynamic fixes, including the ones for DuckDuckGo.

I'm not sure how to support these fixes in an elegant way, especially given that:

  • jsDelivr package for DarkReader doesn't provide dynamic fixes file.
  • Nyxt support for user scripts lacks resource loading at the moment. So, if there is an easily accessible dynamic fixes file, it'll only work when resource loading is there. Contributions welcome, obviously.

aartaka avatar Oct 16 '23 12:10 aartaka

This extension works well on the JS version, so that works for now. I'm still getting the hang of Nyxt, but this issue would be interesting to look into when I get comfortable enough with it.

AblatedSprocket avatar Oct 16 '23 12:10 AblatedSprocket