Artyom Bologov
Artyom Bologov
> OK, looks good to me! > > Sorry for taking so long to come back to this, no excuse really considering how trivial it is :p No problem :)...
Merging now that tests are adjusted?
@aadcg, all addressed, I believe!
@aadcg, I've made yet another revision. Note that the meaning of the security settings keywords shall not be explained in detain in this comment—it's the role of WebKitGTK docs and...
Yes, it closes the issue.
@acidtoyman, sorry for the wait, I just realized my previous comment with code snippet had a typo in it! See the [updated version](https://github.com/atlas-engineer/nyxt/issues/2587#issuecomment-1259235353).
But then, maybe we should set it to one third of the actual window height?
> @aartaka I don't know how to do it. Does GTK give us that? Yes (mostly copy-pasted from renderer/gtk implementation of `ffi-buffer-height`): ``` lisp (gdk:gdk-rectangle-height (gtk:gtk-widget-get-allocation (nyxt/renderer/gtk::gtk-object (current-window)))) ```
I'd say yes, because it's a significant expectations violation.
> Is that violation felt with Nyxt's defaults? If it's not, then I'd say it's not a priority. What do you mean? Nosave buffers are integral to Nyxt. So yes,...