Aarsh Shah
Aarsh Shah
@Stebalien Does this look correct ?
@BigLep Closing this as Im not sure if this is correct and it needs engagement from Steb if we get to it again.
@Stebalien Just to clarify, when we support legacy transactions - do we mean Transactions **_without_** Chain ID OR Transactions without ChainID AND without any of the EIP-1599 gas stuff params...
@Stebalien Are you saying that this wont work ?
Hey @raulk This PR needs a review from someone who understands the ETH RPC stack really well. But @Stebalien is fully focused on F3 currently. Would you or Mikers or...
@rvagg Have addressed both your review comments. Please can you take one final look at the PR ?
@raulk I agree. We have removed the looping so if the user specifies a tipset that can cause an expensive fork, we just error out the request(should be few of...
@momack2 We were waiting on a review from someone who understands the ETHFilecoin stack well. Now that Raul has reviewed it, we can land this. Have addressed the latest round...
Will address @raulk 's response in a future PR when he takes a look at this as we're not changing any pre-existing behaviour here wrt handling migration epochs.
@raulk Can we go ahead and merge this one given that we're now co-ordinating on a separate workstream for events ?