websub.rocks icon indicating copy to clipboard operation
websub.rocks copied to clipboard

subscriber validators 201, 202, 300, 301, 302 do not work as expected

Open pi73jyro opened this issue 7 years ago • 3 comments

The validation tests 201, 202, 300, 301, 302 for the subscriber do not work as I expect them to do:

  • 201/202: They publisher does not respond with a http status code of 301/302 and a http location header. Instead the publisher responds with a http status code 200.

  • 300/301/302: The test ends after a succesful subscription. No content is being delivered by the hub. There is no content notification (http post) being sent.

pi73jyro avatar May 17 '18 09:05 pi73jyro

201 and 202 redirect in the discovery phase, see image of 202 redirecting with a 301 for instance 2018-05-22-163835_622x420_scrot

for 300+ you need to be logged in and click the Continue button and make a manual post

on a side note the registration with the email link is somewhat annoying for test automation, if that could be changed that would be cool

euri10 avatar May 22 '18 14:05 euri10

@euri10 I checked this again and you are right with 201 and 202. The HTTP request library I'm using automatically follows redirections for HTTP GET requests, so the redirection was "hidden" for me. My bad!

You are also right for the 300+. When I'm logged in the behaviour is as expected. But when you are not logged in, the behaviour is a bit unsatisfying.

There's nothing indicating you need to manually make a post to trigger the publisher. The green alert "Subscription activated!" makes you feel like you passed the test, even though no content was distributed. When you click "Continue" there's still nothing saying you need to login and make a post.

01_300

02_300

It's no big deal and a simple text saying "Next Step: You need to login and make a post!" would fix this small issue.

pi73jyro avatar May 23 '18 08:05 pi73jyro

I agree, I had to discover it as well ;)

euri10 avatar May 23 '18 08:05 euri10