micropub.rocks
micropub.rocks copied to clipboard
Show a warning when a CORS request is made to the client
warn that not all Micropub endpoints will support CORS
Seems like the CORS header is currently completely missing from the client tests, I see a CORS error with my micro-panel in standalone mode instead of a warning from micropub.rocks…
That's strange, it's setting them here: https://github.com/aaronpk/micropub.rocks/blob/master/app/ClientTests.php#L1613
What error specifically? Did I leave out a header? Also I was pretty sure I had tested this with a javascript client already.
Is that function called on the client page? Not seeing the header:
ooh it's not! Are you hitting that when you're signing in?
Yep, when requesting /client/… to discover endpoints
Okay, I just added them there. Try now!
Okay, it's there :) Would be nice to also get the endpoints in a Link header, I haven't implemented finding them in HTML…
Yeah I can do that. Can you make a new issue for it?
done