OwnYourGram icon indicating copy to clipboard operation
OwnYourGram copied to clipboard

Published 20 hours ago • verified publisher icon aaronpk

Videos showing up as .jpg

Open jjeaton opened this issue 6 years ago • 4 comments

I see PR #46 that should set a .mp4 extension, however, videos to my site are loading as a gallery of a video thumbnail, followed by the video but with a .jpg extension. If I download, rename to .mp4 and re-upload, it's all fine, but any idea why this isn't working?

jjeaton avatar Sep 07 '18 03:09 jjeaton

This should solve it. However this also tells me that your site is using the filename in the media upload instead of determining its own, which is dangerous in general. (never trust user input etc). Anyway let me know if this fixes it for you.

aaronpk avatar Jan 10 '19 16:01 aaronpk

@aaronpk thanks! I'm using WordPress with the micropub extension, so perhaps it's doing that somewhere in there. I'll have to post a video to test it out.

jjeaton avatar Mar 01 '19 01:03 jjeaton

Micropub on WordPress uses the built in WordPress functions for media upload. There was recently something about how WordPress handled media upload files.

https://make.wordpress.org/core/2018/12/13/backwards-compatibility-breaks-in-5-0-1/

dshanske avatar Mar 01 '19 01:03 dshanske

@aaronpk

I've tested:

  • [x] Can video/mp4 be uploaded to media library?
  • [x] Can video/mp4 be uploaded via core REST API endpoint?
  • [x] Can video/mp4 be uploaded via micropub media endpoint?
  • [x] Can copy_to_media_endpoint by itself, successfully upload a video/mp4? (I pulled it out into a simple script, and it worked.

However, If I hit the "Post" button from OYG, the video is blocked, and my error log has a line that says:

Micropub Error: 500 invalid_request - Sorry, this file type is not permitted for security reasons.

I have no idea why it would be failing if all the other tests pass, but it seems to be an issue with OYG or with the file passed by Instagram.

jjeaton avatar Apr 16 '19 01:04 jjeaton