Aaron DeRuvo

Results 24 issues of Aaron DeRuvo

A set of manual or automated tests to ensure we dont break things

enhancement
Applications
v4
focus:testing

The message for the transaction never changes. Even when the user already approved the transaction, the message displayed is that the user needs to approve it (see the last part...

enhancement

Some Connectors set lastUsedFeeCurrency in LocalStorage on construction, others dont None of them update the value in localStorage when updateFeeCurrency is called Should feeCurrency be saved to localStorage? Probably not...

Applications

set up ts and jest so we can import like `src/thing` rather than `../../src/thing`

Applications

Adds new Celo Cannoli Testnet and updates celo explorer and faucet to latest urls

### Describe the Feature I would like to be able to send and sign transactions which have types beyond null 1 and 2 and which may contain additional parameters. Currently...

enhancement
on-deck
minor-bump
v6

### Expected Behavior can sig eip1559 and the new celo tx with feecurrecy but no gatewayfee ### Current Behavior only signs celo legacy transactions

wallet
Priority: P1
L2

### Expected Behavior [#getMetaTransactionSigner](https://github.com/celo-org/celo-monorepo/blob/b8c37cddaeaa81e473dde97fb55a455f9a121ba0/packages/protocol/contracts/common/MetaTransactionWallet.sol#L202) has a test ### Current Behavior No test found protocol for MetaTransactionWallet#getMetaTransactionSigner [only one in contractkit ](https://github.com/celo-org/celo-monorepo/blob/b8c37cddaeaa81e473dde97fb55a455f9a121ba0/packages/sdk/contractkit/src/wrappers/MetaTransactionWallet.test.ts#L137)

protocol-test

### Expected Behavior can call eth_gasPrice with an argument when running tests ### Current Behavior Celo ganache throws an error when call to eth_gasPrice comes from here https://github.com/celo-org/ganache/blob/soloseng/CELO-support/src/chains/ethereum/ethereum/src/api.ts#L1609

Component: Tests
Component: Ganache

### Currrently Celoterminal only supports WalletConnect Protocol by copying and pasting the `wc` uri into celo terminal app. ### Issue Copying and pasting is not a nice User experience as...